oxalica / nil

NIx Language server, an incremental analysis assistant for writing in Nix.
Apache License 2.0
1.28k stars 39 forks source link

Only strip query parameters and fragment for flake ref URLs #141

Closed uncenter closed 3 weeks ago

uncenter commented 2 months ago

There's no reason to strip these values for non-flake refs, as the comment here itself states: "Trim ? and # parts, which are special for flake-ref." Instead, this behavior was breaking the ability to open other non-flake ref links, like the following from the vscode-extensions section of Nixpkgs where essential query parameters were stripped:

CleanShot 2024-06-17 at 17 29 50@2x