WIP: Allow serializer field configuration to be specified in metadata

oxan / djangorestframework-dataclasses

Dataclasses serializer for Django REST framework

BSD 3-Clause "New" or "Revised" License

429 stars 28 forks source link

WIP: Allow serializer field configuration to be specified in metadata #36

Closed oxan closed 3 years ago

oxan commented 3 years ago

TODO:

[ ] Consider whether supporting both approaches really is a good idea
[ ] Consider metadata keys (I don't really like the current ones)
[ ] Tests
[ ] Documentation

Closes #31

jstasiak commented 3 years ago

This is a big missing feature for me and it'd be great to have it – if there's anything I could do to help (like providing tests or documentation) please let me know.

oxan commented 3 years ago

Yeah, if you could provide tests and documentation that'd help. I'll see if I can find some time to finish, merge and release this later this week.

oxan commented 3 years ago

Though I suppose that's hard to do without the answer to the first two questions. Given that it's just two additional lines of code I've pretty much settled on supporting both approaches (as I can see situations were either is useful), and for now I'll keep the current names, though I may still decide to switch it to serializer_field and serializer_kwargs.

jstasiak commented 3 years ago

I'm sorry I didn't help with this, after all, but I'm happy to see it resolved regardless. :)

oxan commented 3 years ago

No worries! Your comment was the motivation I needed to finally resolve this :)