search

oxan / esphome-stream-server

Stream server (serial-to-wifi bridge) for ESPHome
Other
179 stars 72 forks source link

Add `binary_sensor` #15

Closed joshuaspence closed 1 year ago

joshuaspence commented 2 years ago

Fixes #8. Based on https://github.com/thegroove/esphome-zbbridge/blob/main/custom_components/serial_server/binary_sensor.py.

joshuaspence commented 2 years ago

@oxan Anything else needed before we can merge this?

ruimarinho commented 2 years ago

Looks good!

joshuaspence commented 2 years ago

@oxan are you still interested in this change?

akalagov commented 1 year ago

This is a much needed feature!

oxan commented 1 year ago

Hi! Sorry for the silence, I've neglected this project quite a bit over the last year.

Tonight I've finally finished the major refactoring to port to ESPHome's socket abstractions, which is in PR #25. I've also squashed this PR into that branch, albeit somewhat refactored to not create the binary sensor as a separate component. I want to do some more testing over the weekend, but if that succeeds I'll merge that one into master and we're finally done with this. Thanks for your contribution in any case!

oxan commented 1 year ago

The functionality from this PR has been merged with #25.