oxc-project / backlog

backlog for collborators only
0 stars 0 forks source link

Compact string with precomputed hash #60

Open Boshen opened 4 days ago

Boshen commented 4 days ago

We are commonly hashing Atoms when e.g. building scope tree. Possibly could avoid repeated hashing and memory accesses by storing hash inline in Atom.

Rolldown wants this.

rzvxa commented 4 days ago

Isn't this just a duplicate of https://github.com/oxc-project/backlog/issues/46#issuecomment-2200571540

Boshen commented 4 days ago

Yes, that issue is for a overhaul of the Atom type, where this is just a wrapped type, which should be done separately as two tasks.

rzvxa commented 4 days ago

Yeah sorry for the comment, I came to this conclusion after sending that comment so that's why I marked it as resolved.

overlookmotel commented 4 days ago

Related to #46.