search

oxc-project / oxc-browserslist

Rust port of browserslist
https://docs.rs/oxc-browserslist
MIT License
19 stars 1 forks source link

feat!: change API to accept `&[S]` instead of `IntoIterator<Item = S>` #29

Closed Boshen closed 1 month ago

Boshen commented 1 month ago

This reduces 1 allocation for the common case where the input is a single item &[s]

codspeed-hq[bot] commented 1 month ago

CodSpeed Performance Report

Merging #29 will degrade performances by 9.66%

Comparing api (b40f356) with main (15c23bf)

Summary

❌ 1 regressions ✅ 5 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main api Change
❌ resolve 'node >= 8' 182.3 µs 201.8 µs -9.66%
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.14%. Comparing base (15c23bf) to head (b40f356).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #29 +/- ## ========================================== - Coverage 98.14% 98.14% -0.01% ========================================== Files 49 49 Lines 2432 2431 -1 ========================================== - Hits 2387 2386 -1 Misses 45 45 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.