Oxlint configuration file setting

oxc-project / oxc-intellij-plugin

25 stars 2 forks source link

Oxlint configuration file setting #84

Open nrayburn-tech opened 1 week ago

nrayburn-tech commented 1 week ago

The VS Code plugin currently only supports specifying a single configuration file. However, the CLI supports nested configuration files. The IntelliJ Eslint plugin supports various configuration options.

What should be supported by the Oxc IntelliJ plugin?

Support for specifying a single configuration file is relatively straightforward to implement. However, it comes with the problem that nested configs won’t work and you may have different results between the CLI and the plugin.
Support for nested configs and automatic resolution is more difficult, but probably a better user experience. May require language server enhancements to benefit VS Code and IntelliJ plugins.

nrayburn-tech commented 1 week ago

@DonIsaac not sure if you have any thoughts on this. I assume we would want VS Code and IntelliJ plugins to have similar behavior where possible.

I think that if the language server was enhanced to automatically resolve the configuration file for a given input file, then we would be able to have consistent behavior in both plugins and improve the user experience.

https://eslint.org/docs/latest/use/configure/configuration-files#configuration-file-resolution is what I’m referring to if it wasn’t clear. Just that sort of behavior in the language server when publishing diagnostics.

DonIsaac commented 1 week ago

We don't support nested configs yet. I'm working on overrides this week and will be tackling that next. Afterwards, I think nested configs will get handled by the language server and not the editor plugin. Still need to hammer out file naming conventions.

nrayburn-tech commented 1 week ago

Sounds good to me. In the meantime, I might just match the VS Code functionality with a path to a single config to have something a bit more releasable for the plugin. Then it can be enhanced later.

nrayburn-tech commented 1 week ago

Per https://github.com/oxc-project/oxc-intellij-plugin/issues/54#issuecomment-2439823679, just going to wait for the nested config support. The first IntelliJ plugin release will hopefully come sometime shortly after that.