oxc-project / oxc-resolver

Rust version of webpack/enhanced-resolve
https://oxc.rs/docs/guide/usage/resolver.html
MIT License
122 stars 18 forks source link

feat(napi): add tracing via `OXC_LOG:DEBUG` #202

Closed Boshen closed 3 months ago

codspeed-hq[bot] commented 3 months ago

CodSpeed Performance Report

Merging #202 will not alter performance

Comparing tracing (5396d38) with main (1920b55)

Summary

✅ 2 untouched benchmarks

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.84%. Comparing base (1920b55) to head (5396d38). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #202 +/- ## ======================================= Coverage 96.84% 96.84% ======================================= Files 11 11 Lines 2284 2284 ======================================= Hits 2212 2212 Misses 72 72 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ematipico commented 3 months ago

Just a nitpick: DEBUG can imply that there might be other levels of logging. Do you plan to add them?

Boshen commented 3 months ago

Just a nitpick: DEBUG can imply that there might be other levels of logging. Do you plan to add them?

I may add other INFO logs when the current information is insufficient for complicated situations.

Boshen commented 3 months ago

Oh, I see a trace here tracing::trace!(tsconfig = ?tsconfig, "load_tsconfig"); 😅

ematipico commented 3 months ago

It's actually the other way around. Info gives less information, and trace gives more information than debug