oxc-project / oxc-resolver

Rust version of webpack/enhanced-resolve
https://oxc.rs/docs/guide/usage/resolver.html
MIT License
122 stars 18 forks source link

fix: remove `#[cfg(target_os = "windows")]` logic in `canonicalize` #221

Closed Brooooooklyn closed 3 months ago

Brooooooklyn commented 3 months ago

I should have checked the file changes before click the resolve conversation button :(

CleanShot 2024-07-10 at 22 47 27@2x

Brooooooklyn commented 3 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Brooooooklyn and the rest of your teammates on Graphite Graphite

codspeed-hq[bot] commented 3 months ago

CodSpeed Performance Report

Merging #221 will not alter performance

Comparing 07-10-fix_missed_changes_before_220_merged (6d1b0a1) with main (b6eeab6)

Summary

✅ 3 untouched benchmarks

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.95%. Comparing base (b6eeab6) to head (6d1b0a1). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #221 +/- ## ========================================== - Coverage 96.95% 96.95% -0.01% ========================================== Files 11 11 Lines 2298 2297 -1 ========================================== - Hits 2228 2227 -1 Misses 70 70 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Boshen commented 3 months ago

No behavior change, hot fix is not needed.