oxc-project / oxc-resolver

Rust version of webpack/enhanced-resolve
https://oxc.rs/docs/guide/usage/resolver.html
MIT License
122 stars 18 forks source link

feat(napi): expose module type info in ResolveResult #223

Closed Brooooooklyn closed 3 months ago

Brooooooklyn commented 3 months ago

See https://github.com/oxc-project/oxc-node/blob/main/src/lib.rs#L345-L358 for the context:

We need to know the module type for resolved paths, so we can pass it to the Node.js import loader hook.

This can also fix https://github.com/swc-project/swc-node/issues/788

Brooooooklyn commented 3 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Brooooooklyn and the rest of your teammates on Graphite Graphite

codspeed-hq[bot] commented 3 months ago

CodSpeed Performance Report

Merging #223 will not alter performance

Comparing 07-11-feat_napi_expose_module_type_info_in_resolveresult (95b605a) with main (5d4421a)

Summary

✅ 3 untouched benchmarks

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.95%. Comparing base (5d4421a) to head (95b605a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #223 +/- ## ======================================= Coverage 96.95% 96.95% ======================================= Files 11 11 Lines 2297 2297 ======================================= Hits 2227 2227 Misses 70 70 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.