search

oxc-project / oxlint-ecosystem-ci

Oxlint Ecosystem CI
4 stars 1 forks source link

add vscode repo #13

Closed Boshen closed 1 week ago

Boshen commented 1 week ago

Still failing :-(

rzvxa commented 1 week ago

I'll take care of it

rzvxa commented 1 week ago

@Boshen I've run the tests again and no sign of false positives, There are some rules-of-hooks errors but I think they are all expected. I guess from the day you created this PR till now I've fixed it, We can track the last CI run checkout commit if you want to know which change resulted in it being fixed.

Boshen commented 1 week ago

included the other cfg rules

rzvxa commented 1 week ago

I think all no-fallthrough diagnostics are accurate, I'll investigate them right away. As for getter-return false positives I'm working on them in this PR https://github.com/oxc-project/oxc/pull/3714, If I'm not mistaken this particular one is already fixed, I'll check it out and if it is I'll extract it to its own PR so it can be merged sooner.

rzvxa commented 1 week ago

you should merge this first https://github.com/oxc-project/oxc/pull/3714