search

oxc-project / playground

Oxc Playground
https://playground.oxc.rs
MIT License
20 stars 7 forks source link

Use shiki for monaco highlighting #37

Closed IWANABETHATGUY closed 2 months ago

IWANABETHATGUY commented 2 months ago 
          we can use shiki for monaco highlighting

Originally posted by @sxzz in https://github.com/oxc-project/playground/issues/36#issuecomment-2328172572

sxzz commented 2 months ago

I tried the PR #35 you previously optimized bundle size for Monaco Editor. I found that not only was highlighting missing, but also code suggestions.

If using this simplified version of Monaco editor, it would be even worse than using CodeMirror. So for a good DX, I think the size is worth it.