search

oxc-project / playground

Oxc Playground
https://oxc-playground.netlify.app/
MIT License
3 stars 2 forks source link

feat: add playground website layout #7

Closed eryue0220 closed 2 months ago

eryue0220 commented 2 months ago

This pr is part of the new playground, and it just added layout and theme, and a new sidebar for the oxc configurations. image image

netlify[bot] commented 2 months ago

Deploy Preview for oxc-playground ready!

Name Link
Latest commit 41079c5087efb7cd8467febe2a77da1e781bb2bb
Latest deploy log https://app.netlify.com/sites/oxc-playground/deploys/6652e9cae1e9e80008575768
Deploy Preview https://deploy-preview-7--oxc-playground.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Boshen commented 2 months ago

Should we be using a component library? What is the source of the included components?

Boshen commented 2 months ago

I see a warning: [@vue/compiler-sfc]definePropsis a compiler macro and no longer needs to be imported.

Boshen commented 2 months ago

@Dunqing please take a look, I think you want to use some specific libraries?

Dunqing commented 2 months ago

Should we be using a component library?

I think we should be. The component library can save a lot of time. Also, headless-ui components is easy to modify.

What is the source of the included components?

I'm sorry, I don't understand what you're asking.

Dunqing commented 2 months ago

I prefer to use UnoCSS instead of TailwindCSS. The UnoCSS has a lot of presets we can use. Like unocss-preset-theme preset can help us quickly support light/dark themes. But I'm not sure if this can work well with shadcn-vue.

Boshen commented 2 months ago

Let's try https://github.com/radix-vue/shadcn-vue, we would be dog fooding ourselves as well https://github.com/radix-vue/shadcn-vue/blob/63bb21808fb36e04e32f8462cb2aef47082d98f9/packages/module/package.json#L39

Boshen commented 2 months ago

@eryue0220 Can you take a look at shadcn-vue and see if you can replace this PR's component usage with it?

eryue0220 commented 2 months ago

@eryue0220 Can you take a look at shadcn-vue and see if you can replace this PR's component usage with it?

Yes, I used shadcn-vue, but it's a little different. The components' code will be installed in the repo instead of node_modules. And in this project, the shadcn-vue components' code was installed in src/ui, and the src/component/ui just wrap some business code based on it.