search

oxdc / obsidian-vertical-tabs

An Obsidian plugin that displays open tabs vertically, allowing users to group and organize tabs for a better navigation experience.
MIT License
72 stars 0 forks source link

Mobile compatibility: No ability to close tab on mobile #52

Open hdsateyate opened 1 week ago

hdsateyate commented 1 week ago

On version 0.10.0 it is not possible to close tabs on mobile. I updated just now, I'm not sure what version I was on before I updated.

Previously the icon was not visible (due to requiring hover) but the functionality was there if you pressed in the right area which was working for me.

Now it appears the button does not exist on mobile at all, making it visible in CSS does nothing.

Please bring back the close tab functionality and make it visible at all times on mobile.

Thanks!

oxdc commented 1 week ago

Thank you for your feedback.

Previously the icon was not visible (due to requiring hover) but the functionality was there if you pressed

Yes. This button is designed for desktop, not tuned for mobile.

making it visible in CSS does nothing.

I'm sorry but CSS won't bring it back since I have completely removed this button from mobile platforms. It simply does not exist.

On version 0.10.0 it is not possible to close tabs on mobile.

You may long press the tab to open the context menu and close the tab or other tabs from there.

Please bring back the close tab functionality and make it visible at all times on mobile.

I'm working on a better design, please wait patiently. As I said, previously the icon is suitable for desktops but for mobile. I found it is too easy to accidentally close a tab, which might cause trouble for many users.

hdsateyate commented 1 week ago

Did you get many complaints in relation to people closing tabs accidentally?

An alternative flow to address that outcome would be an undo close toast that pops up for a few seconds as in Chrome for example.

hdsateyate commented 1 week ago

Another alternative would be swipe to close but I expect that is significantly more work than bringing back the old functionality and implementing an undo.

In fact the undo would be useful in both instances.

oxdc commented 1 week ago

Thank you! I'll consider your suggestions.

Did you get many complaints in relation to people closing tabs accidentally?

Yes. And myself encountered this problem as well.

an undo close toast

Unfortunately, this is not possible for the current architecture design. I'll work on this problem in the near future.

oxdc commented 6 days ago

Hi @hdsateyate , you may try closing a tab by double tapping it on mobile. I'm not sure if this is the right design. Might be removed in the future. Please feel free to share your thoughts!

hdsateyate commented 6 days ago

Hi @hdsateyate , you may try closing a tab by double tapping it on mobile. I'm not sure if this is the right design. Might be removed in the future. Please feel free to share your thoughts!

I don't mind it. Happy to live with that, thanks.

However, now that you have brought my attention to it, it would be preferable to me for the sidebar not to auto-close after a double tap close action, what do you think?

Quite often when I am in the sidebar closing tabs it is because I want to close multiple tabs quickly having to reopen the sidebar each time provides a little more friction.

Many thanks,

oxdc commented 6 days ago

having to reopen the sidebar each time

Yeah, that is why I think this is not a good design. I will try to pin the sidebar or something else like swipe menu, not sure if these could work. Thank you for sharing your thoughts!