search

oxen-io / eth-sn-contracts

4 stars 8 forks source link

Devnet #93

Closed jagerman closed 4 days ago

jagerman commented 1 week ago

This PR is for tracking our internal devnet, which is currently running on the latest PRs and WIP branches as merged here.

Not for review/merging until after the included relevant PRs are finalized and merged.

darcys22 commented 4 days ago

The scripts for deploy-devnet and deploy-testnet seem to only have the staking requirement and the pooled amounts as differences. Feels like they should be a single script that can deploy to both instead of 2 separate scripts. Hardhat scripts cant take parameters directly but maybe we should have an ENV variable defining if its DEVNET/STAGENET and reading appropriate config variables depending on that.

Deploy-local-test should probably be doing the same deployment scripts aswell.

jagerman commented 4 days ago

The scripts for deploy-devnet and deploy-testnet

Was this an early PR comment (I think it was)? deploy-devnet.js and deploy-stagenet.js are tiny scripts now that call into testnet-common.js (the only difference being the token name/symbol).

deploy-local-test.js is a bit different as it uses various different parameters in the SNRewards deployment that I (think?) would break test code if it changed.

Doy-lee commented 4 days ago

I'll add a note to review unifying local-test to our tracker and get this merged in