DNS message parsing fixes and cleanup - Githubissues

oxen-io / lokinet

Lokinet is an anonymous, decentralized and IP based overlay network for the internet.

https://lokinet.org/

GNU General Public License v3.0

1.79k stars 224 forks source link

DNS message parsing fixes and cleanup #1962

Closed jagerman closed 2 years ago

jagerman commented 2 years ago

NB: Builds on #1955 -- only the last commit is relevant to this PR.

Fixes:

tighten reserved name detection to not match fooloki.loki, but instead only match "foo.loki.loki" and "loki.loki" (and similar for reserved name "snode.loki").
IPv6 PTR parsing was completely broken.
Added tests for the above two issues.

Cleanups:

Eliminate llarp::dns::Name_t typedef for std::string
Use optional return instead of bool + output param
Use string_views; we were doing a lot of string substr's during parsing, each of which allocates a new string.
Use fmt instead of stringstream
Simplify IPv4 PTR parsing

majestrate commented 2 years ago

lint