search

oxen-io / lokinet

Lokinet is an anonymous, decentralized and IP based overlay network for the internet.
https://lokinet.org/
GNU General Public License v3.0
1.71k stars 221 forks source link

Fix incorrect usage of oxen-logging syslog #2120

Closed tewinget closed 1 year ago

tewinget commented 1 year ago

Previously oxen-logging was erroneously hard-coded to use the target "lokinet" for system logs. Obviously this is wrong for anything else which uses oxen-logging and the system log. This changes our call to add_sink to pass "lokinet" as the target rather than the config filename, and updates oxen-logging to use that argument correctly.

majestrate commented 1 year ago

you need to bump the required oxen-logging version in external/CMakeLists.txt

tewinget commented 1 year ago

I don't see that as one of the submodules which has such a requirement, i.e. it appears it's always built from source?

majestrate commented 1 year ago

ah, nevermind i thought we had one for that like oxenc

jagerman commented 1 year ago

Yeah, oxen-logging doesn't have releases (so far); we always build it from source in all three projects using it.