search

oxen-io / oxen-core

Oxen core repository, containing oxend and oxen cli wallets
https://oxen.io
Other
314 stars 120 forks source link

Fix AllowShortBlocksOnASingleLine and SortIncludes clang values #1722

Closed javabudd closed 3 weeks ago

javabudd commented 3 weeks ago

AllowShortBlocksOnASingleLine had a value of false which is invalid, the value of Never should maintain prior behavior.

SortIncludes had a value of true which is invalid. CaseSensitive should maintain prior behavior.

Doy-lee commented 3 weeks ago

LGTM, confirmed on an older release 16.0.0

https://releases.llvm.org/16.0.0/tools/clang/docs/ClangFormatStyleOptions.html#allowshortblocksonasingleline https://releases.llvm.org/16.0.0/tools/clang/docs/ClangFormatStyleOptions.html#sortincludes

And on the latest release

https://clang.llvm.org/docs/ClangFormatStyleOptions.html#allowshortblocksonasingleline https://clang.llvm.org/docs/ClangFormatStyleOptions.html#sortincludes

Doy-lee commented 3 weeks ago

Thanks for the contribution 👍