oxen-io / oxen-core

Oxen core repository, containing oxend and oxen cli wallets
https://oxen.io
Other
308 stars 116 forks source link

Explicitly disable merged mining #620

Open jagerman opened 5 years ago

jagerman commented 5 years ago

I'd like to propose that in the next fork we forcibly disallow merge mining by requiring that coinbase transactions in the next network version do not include coinbase transactions with merge mining tags (i.e. the tx extra field TX_EXTRA_MERGE_MINING_TAG 0x03).

Merged mining has been, on the whole, a fairly undesirable feature. Although it wasn't intentional, it ended up putting burdens on pools to support it, and (early on) had some pools throwing out dirty hacks in order to get it working: one pool stopped including any transactions in blocks; another made the coinbase transaction version 1 (requiring us to fix in #588), which resulted in the resulting block rewards being unspendable (for the pool itself, which seems fair, but also for SNs and the governance wallet, which is not).

The tradeoff has been, of course, a significant hashrate increase. With the upcoming checkpointing support, however, this hashrate is essentially pointless: we don't need it to secure the network against 51% attacks. Instead that role now moves to service node checkpointing quorums, which are considerably more difficult (and expensive) to take control of than a short-term 51% mining attack has been.

Thus this issue to discuss the matter.

necro-nemesis commented 5 years ago

Concur. It further highlights the strength of the project and the efforts put into development of check pointing and the node network. This is one aspect where Loki core shines. Merge mining should be a concern of other projects and not Loki as Loki has diligently worked to overcome shortfalls others are willing to compromise and accept. Go Loki core!

Dormage commented 5 years ago

I support the idea. Aside from the technical issues one can argue merged mining is in part devaluing Loki.

Initially merged mining was very profitable. However, through economics, the system stabilized the value across both chains resulting in a significantly lower valuation of Loki.

As a result, miners that supported the network from the very beginning and held Loki as a speculative investment (rather then selling to cover the costs of mining) are now having their investment devalued.

KeeJef commented 5 years ago

I disagree with this change atleast until checkpointing commences, at this point our hashrate is exceedingly well distributed across a number of pools, with no pool having a majority hashrate or even close to it https://miningpoolstats.stream/loki

I would attribute most of this to merge mining with turtlecoin which is right now providing Loki double the security and a more decentralized mining pool distribution, Turtle will fork to thier new Argon2 based hashing algorithm at block 1,800,000 with a current block height on turtlecoin of 1,588,887 and a blocktime of 30s we should see the fork happen some time around ~August the 29th. If everything goes well for checkpointing we are scheduled for an activation date of ~September the 12th. this will mean we will maintain a high degree of protection by combining turtlecoin hashrate and Loki hashrate till that point.

Once checkpointing is enabled im open to the idea of disabling Merge mining, however i think its somewhat unclear what the risk/benefits are longterm of enabling merged mining are. For a good example of where merge mining has worked for security we can look at Namecoin which about 90% of Bitcoin miners are mining https://bitinfocharts.com/comparison/hashrate-btc-nmc.html

If the Loki community agreed to reduce the block reward percentage allocated to Miners and still requires miners to create blocks and derive randomness (one option). then it would be good to maintain a high and stable hashrate, which could be achieved by pairing with a parent coin to derive hashrate.

bobbieltd commented 5 years ago

Thanks to your opinion, I got my lesson. A complete 180. There are many options to deal with merged mining but you propose the radical one (if we do not like it, we kill it).

Dormage commented 5 years ago

If the Loki community agreed to reduce the block reward percentage allocated to Miners and still requires miners to create blocks and derive randomness (one option). then it would be good to maintain a high and stable hashrate, which could be achieved by pairing with a parent coin to derive hashrate.

I think this would work. Also, AFAIK, the initial idea was to change this after check-pointing is implemented. Arguably, merged mining has increased network security but I would argue it has also effected the price action considerably. This has effected service node operators who are not struggling even to cover the costs of hosting.

Full disclosure, I operate 7 service nodes.

SomethingGettingWrong commented 5 years ago

In the case of decentralized emission.... when you have a single entity thats 75 percent more profitable it centralizes the emission and does the exact same thing as a premine. so its imperative a coin does something exp on a coin like loki. If hes is allowed 75 percent for an x amount of time.. then stakes it.. anonyomity of the service nodes is gone and he will forever have x amount of emission right now the turtlecoin is being mergemined and the hashrate is not securing anything on the network once checkpoints are implemented. majority of the hashrate is FPGA he should not be allowed to mine on it now or later with FPGA being a solo miner

If you mine with a mining rig on gpus right now.... you are -75 percent in the hole... you burn 3/4 more in electricity then you get loki!

Having a diffrent hashvalue... that fpga is giving Loki has the illusion of decentralized mining. but if you look at -75 percent in the hole you know something is off. There needs to be an algo change asap even if you dont think it has to do with price