[X] I have tested my contribution on these devices:
Samsung S9+ Android 9 / API 28Device B, Android Z.Y
Virtual Android 9 / API 28
Virtual Android 14 / API 34
[X] My contribution is fully baked and ready to be merged as is
[X] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234syntax
Description
It has been decided that when receiving a new, long message when we are scrolled to the bottom of the conversation RecyclerView we should scroll to the bottom of the received message, see: https://optf.atlassian.net/browse/SES-789
This PR adjusts the scroll functionality to act in that manner. Tested by sending a variety of small and large (20/30/40/50+ line) messages between devices running this branch and confirming the updated behaviour works as intended.
The modification is essentially a single line in the ConversationAdapterDataObserver at the bottom of the ConversationActivity, and I made the adjustment on top of the scrolling-related PR: https://github.com/oxen-io/session-android/pull/1415 (which I also merged the most recent dev branch into). As PR1415 hasn't been merged yet it looks like there are a number of small changes in this PR, but if that PR is merged first then this PR is essentially a single line (and a comment) at lines 2165-to-2168 of the ConversationActivity.
Contributor checklist
Fixes #1234syntaxDescription
It has been decided that when receiving a new, long message when we are scrolled to the bottom of the conversation RecyclerView we should scroll to the bottom of the received message, see: https://optf.atlassian.net/browse/SES-789
This PR adjusts the scroll functionality to act in that manner. Tested by sending a variety of small and large (20/30/40/50+ line) messages between devices running this branch and confirming the updated behaviour works as intended.
The modification is essentially a single line in the
ConversationAdapterDataObserverat the bottom of the ConversationActivity, and I made the adjustment on top of the scrolling-related PR: https://github.com/oxen-io/session-android/pull/1415 (which I also merged the most recentdevbranch into). As PR1415 hasn't been merged yet it looks like there are a number of small changes in this PR, but if that PR is merged first then this PR is essentially a single line (and a comment) at lines 2165-to-2168 of the ConversationActivity.