oxen-io / session-android

A private messenger for Android.
https://getsession.org
GNU General Public License v3.0
1.86k stars 170 forks source link

[BUG] Deleting all message in a conversation will delete the conversation and contact #1443

Open wreps8Owt opened 6 months ago

wreps8Owt commented 6 months ago

Code of conduct

Self-training on how to write a bug report

Is there an existing issue for this?

Current Behavior

After upgraded to 1.18.1 (3695), if all message in a conversation is deleted (either maually or via Disappearing message), the corresponding conversation and contact may be lost when reopening the session app or returning to the main UI.

Expected Behavior

Up to 1.17.5 (3605), deleting all message in a conversation will not delete the whole conversation and corresponding contact.

Steps To Reproduce

  1. Accept a message request to start a conversation and add a contact.
  2. Send a message.
  3. Delete the message just sent.
  4. Return to the main UI.
  5. One can see that the conversation is removed with the corresponding contact.

Android Version

Android 14

Session Version

1.18.1 (3695)

Anything else?

Leaving at least one non-Disappearing Message in the conversation could keep it.

session11 commented 6 months ago

I was about to open the same issue and found this thread. I confirm the behavior stated in the main post. It would be really nice if an empty conversation would not delete itself.

pottsandpans commented 4 months ago

This is being tracked internally via Jira SES-1723