oxen-io / session-android

A private messenger for Android.
https://getsession.org
GNU General Public License v3.0
1.73k stars 165 forks source link

[SES-824] Onboarding Overhaul Chunk 2 #1451

Open bemusementpark opened 2 months ago

bemusementpark commented 2 months ago

onboarding

Create Account

Screenshot_1718772782

Screenshot_1718772919

Screenshot_1718772796

Screenshot_1718772812

Screenshot_1718772815

Screenshot_1718772823

Screenshot_1718772829

Screenshot_1718772833

Screenshot_1718772854

Screenshot_1718772859

Screenshot_1718772863

Screenshot_1718772871

Screenshot_1718772877

Screenshot_1718772880

I have an account

Screenshot_1718773146 Screenshot_1718773160

Screenshot_1718773135

Screenshot_1718773171

Screenshot_1718773181

Screenshot_1718773183

Screenshot_1718773187

Screenshot_1718773212

AL-Session commented 3 weeks ago

"Recovery Phrase" is still found throughout in the strings

Onboarding will likely come to me next as I'm handling the string updates (which do not contain any mention of recovery phrase - it's always "recovery password"). Although saying that, I'm not certain if onboarding will be released without being combined with my strings branch first: https://github.com/AL-Session/session-android/tree/strings

I'll check with Rebecca.

ThomasSession commented 3 weeks ago

"Recovery Phrase" is still found throughout in the strings

Onboarding will likely come to me next as I'm handling the string updates (which do not contain any mention of recovery phrase - it's always "recovery password"). Although saying that, I'm not certain if onboarding will be released without being combined with my strings branch first: https://github.com/AL-Session/session-android/tree/strings

I'll check with Rebecca.

Yeah these inter dependencies are making things a little tricky. We can't verify the ACs properly unfortunately...

ThomasSession commented 2 weeks ago

Screenshot_1718587542 Issue with the button's text on smaller devices

bemusementpark commented 2 weeks ago

Issue with the button's text on smaller devices

You can't reply directly to general comments.

so, I centered the text in the button and centered the buttons vertically.

bemusementpark commented 2 weeks ago

Hey @ThomasSession

I just fixed a few things:

  1. text selection colors use actual primary color including ocean and overrides.
  2. new message times out properly now as the transition from flow to suspend had some regressions.
  3. button colors should be all good.

PTAL

bemusementpark commented 1 week ago

@ThomasSession I'll probably leave classic_dark_0 in colors.xml as it is used/misused a lot and changing these would broaden the scope further.

Screen Shot 2024-06-22 at 1 22 50 pm