SES1628 - Add git commit details to version info

oxen-io / session-android

A private messenger for Android.

https://getsession.org

GNU General Public License v3.0

1.73k stars 165 forks source link

SES1628 - Add git commit details to version info #1459

Closed AL-Session closed 2 months ago

AL-Session commented 2 months ago

Contributor checklist

[X] I have tested my contribution on these devices:
- Virtual Pixel 3a, Android 14 API 34
[X] My contribution is fully baked and ready to be merged as is
[X] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Adds the first 6 chars of the current git commit hash used to build the app to the "Version: [foo]" details in the Settings activity.

KeeJef commented 2 months ago

LGTM, not sure about

Is this just supposed to be on emulators and/or debug build?

I'm not sure the formatting of v1.17.15 (1705 - aef726) is the most readable, I guess there's no designs for this.

This will be a fairly useful piece of information for non debug / emulator builds too, for example if we are doing internal user tests and users are on different builds.
I think the visual display of this is fine for now, its not a highly exposed feature, being at the bottom of the settings.