oxen-io / session-android

A private messenger for Android.
https://getsession.org
GNU General Public License v3.0
1.73k stars 165 forks source link

[BUG] Message State Issues #1461

Closed AL-Session closed 2 months ago

AL-Session commented 2 months ago

Code of conduct

Self-training on how to write a bug report

Is there an existing issue for this?

Current Behavior

Some message state issues have been observed and are tracked internally as: https://optf.atlassian.net/browse/SES-1718

While unable to reproduce the observed issues, we have co-opted this ticket to fix up the message state displayed to users, namely: 1 - The delivery status for messages that have not yet been delivered or for which delivery has failed should always be displayed, and 2 - The delivery status of "Sending" wasn't displaying for long (it would go "Sending" -> blank for a while -> "Sent". 3 - Disappearing message timers and delivery the status text/image combo wasn't quite right.

Expected Behavior

1.) The delivery status of all messages which have not yet been confirmed as sent, or which have failed to send, should always be displayed.

2.) The delivery status of messages should be the sequence "Sending" -> "Sent" from a user's visual perspective, or "Sending" -> "Failed to send" -> "Sending" -> "Sent" [if we finally succeed] or "Failed to send" [if we finally give up].

3.) When sending disappearing messages we do not display the disappearing message timer when we are in the process of sending the message (as we are showing the delivery status text & image), then on successful send we DO show the timer and only show the delivery status text of the final sent message or any message which has not yet sent or has failed.

Steps To Reproduce

Sent messages, observe current behaviour using disappearing messages off, delete after send, and delete after read.

Android Version

Android Any

Session Version

v.1.18.1

Anything else?

No response