search

oxen-io / session-android

A private messenger for Android.
https://getsession.org
GNU General Public License v3.0
1.73k stars 165 forks source link

Remove fast mode options from website build variant #1482

Open bemusementpark opened 1 month ago

bemusementpark commented 1 month ago

It seems our website build variant already avoids cloud messaging.

This PR skips the activity for choosing to use it or not, and the preference that does the same thing. This option would have no effect anyway.

This is a good step towards a play-services-free build on Fdroid, as these screens would be concerning to privacy-centric users, and misinformation to others who expected that they would benefit from fast mode.

https://github.com/oxen-io/session-android/issues/1427

KeeJef commented 1 month ago

I'd like to keep the option for Play services in the website APK, at least until we develop a more reliable option for delivering notifications when Play services aren't available. One idea was a persistent foreground service which polls/subscribes for notifications for new messages, which i think can be achieved by displaying a persistent notification.

bemusementpark commented 1 month ago

This PR doesn't remove play services from website It was already gone.

So the UI gave you options that didn't do anything.

KeeJef commented 1 month ago

Oh in that case we should actually add play store functionality back into the website APK's imo, not sure why it was removed in the first place