oxen-io / session-android

A private messenger for Android.
https://getsession.org
GNU General Public License v3.0
1.73k stars 165 forks source link

[BUG] ANR caused by last sent message lookup & re-spawning attachment download jobs #1483

Closed AL-Session closed 1 month ago

AL-Session commented 1 month ago

Code of conduct

Self-training on how to write a bug report

Is there an existing issue for this?

Current Behavior

App can cause a App Not Responding (ANR) issue due to a combination of inefficient 'last sent message' queries and a bug whereby attachment download jobs get recreated immediately for the same attachment when they hit their fail limit and should move to a permanently failed state.

Expected Behavior

No or at the very most minimal ANRs reports under any circumstances.

Steps To Reproduce

Use the app with large communities / groups / conversations I would imagine - ANR data is from Play Store reports.

Android Version

Android all

Session Version

1.18.2

Anything else?

PR for this issue incoming - ticket is SES1901.