slrslr
commented
6 days ago For year/s I am not receiving new message request desktop notifications on Session desktop (Linux appimage) - Debian 11+KDE. Community and PM(DM) notifications works.
This PR should be supposedly fixing the issue https://github.com/oxen-io/session-android/issues/1039#issuecomment-1933306582 but the issue remains. Can you please check why? @AL-Session @simophin ...
UPDATE: I have found that under different account ID on same desktop computer, message request arrived. The problematic account ID has some problem with sync currently, due to too big config (message?).
Contributor checklist
[X] I have tested my contribution on these devices:
[X] My contribution is fully baked and ready to be merged as is
[X] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the
Fixes #1234syntaxDescription
Message request push notifications now display, but only a single message request notification per sender to avoid being spammed with message requests. Following clearing of the message requests another message request notification may display (if the user does not specifically accept or decline the message request).
Note: There is a issue where the number of message requests may not be correct, but this will be raised as a separate ticket.
IMPORTANT:
This PR supersedes https://github.com/oxen-io/session-android/pull/1414 which will be closed (comes from my old repo & is a bit janky).