oxen-io / session-android

A private messenger for Android.
https://getsession.org
GNU General Public License v3.0
1.9k stars 173 forks source link

Talkback accessibility #850

Open davidbtc2009 opened 2 years ago

davidbtc2009 commented 2 years ago

Code of conduct

Describe the bug

Talkback screen reader reads the profile button and search button on the main screen as "unlabeled" and the "+" icon cannot even be focused. It goes from the last chat in the list back to the unlabeled profile button. Once the "+" icon is clicked visually the globe icon, message bubble icon, snd group icons are also not able to be focused in order to be used by talkback. When inside a chat the "+" button and microphone are not usable by talkback as they cannot be focused.

To reproduce

  1. Open Settings > Accessibility > Talkback and turn it on
  2. Open session
  3. Swipe through the icons on the main screen
  4. Then open a chat and swipe through the chat screen

Smartphone (please complete the following information):

KeeJef commented 1 year ago

Might we worth tracking this @burtonemily

KeeJef commented 1 year ago

Some of these screens have changed since this issue was filed, but could be a good first issue to correct any discrepancies here

shortwavesurfer2009 commented 1 year ago

@KeeJef updating this issue. The profile and search buttons on the chat list screen are still unlabeled. The "+" icon now focuses correctly but still reads as "unlabeled". When inside a chat the "+" icon to the left of the message box and the microphone )/send button (depending on if a message has been typed also cannot be focused.

burtonemily commented 1 year ago

Might we worth tracking this @burtonemily

This should be fixed up when the Accessibilty ID's branch is merged @hjubb

pbsinnett commented 1 year ago

Hello,

I'm running Session 1.16.7 and experiencing the following accessibility bugs:

If I come across anything else, I'll comment here.

Thanks, Blake

hjubb commented 1 year ago

Thanks @pbsinnett, is there any particular accessibility practices you would expect for those items? The actual content instead? We can probably mark those things down as something to improve on and bring it more in line with what standard practices would be

pbsinnett commented 1 year ago

Yes, that would indeed be preferred. Generally the same info that is available to sighted folks should be available to screen reader users. For voice messages, information that it’s a voice message, the time, length and size (if also shown) should all be spoken. If you aren’t using custom controls, you don’t need to include the control type in the label. Accessibility services take care of that.

From: Harris @.> Sent: Monday, April 10, 2023 2:35 AM To: oxen-io/session-android @.> Cc: Blake Sinnett @.>; Mention @.> Subject: Re: [oxen-io/session-android] Talkback accessibility (Issue #850)

Thanks @pbsinnetthttps://github.com/pbsinnett, is there any particular accessibility practices you would expect for those items? The actual content instead? We can probably mark those things down as something to improve on and bring it more in line with what standard practices would be

— Reply to this email directly, view it on GitHubhttps://github.com/oxen-io/session-android/issues/850#issuecomment-1501503225, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA5SPDNBB4UWNGZGSGX7UFDXAOZZXANCNFSM5O6SWIZQ. You are receiving this because you were mentioned.Message ID: @.**@.>>

shortwavesurfer2009 commented 11 months ago

The things that @pbsinnett mentioned are still issues as of now v1.17.4