search

oxen-io / session-desktop

Session Desktop - Onion routing based messenger
https://getsession.org
GNU General Public License v3.0
1.56k stars 196 forks source link

Session desktop doesn't know what country the node is in #2219

Closed LittleBigTea closed 2 years ago

LittleBigTea commented 2 years ago

Describe the bug When I click on the connection button which is supposed to show the nodes my messages are being sent through, some of them appear as undefined

To Reproduce Let session running

Screenshots or Logs Session_2Gxdc27SIB session_debug_1647540898686.log

Bilb commented 2 years ago

We use this module to find without request where is located an ip. https://www.npmjs.com/package/ip2country And sometimes that offline list is not 100%.

SArpnt commented 2 years ago

was there any related commit? whether or not it's possible to find the location it still says undefined, which doesn't work with the ui and gives me the impression other code might have issues with it. it should say something like unknown.

ianmacd commented 2 years ago

was there any related commit? whether or not it's possible to find the location it still says undefined, which doesn't work with the ui and gives me the impression other code might have issues with it. it should say something like unknown.

There's an outstanding PR (#2280) that would fix this issue.