Add download all attachments to messages.

oxen-io / session-desktop

Session Desktop - Onion routing based messenger

https://getsession.org

GNU General Public License v3.0

1.44k stars 187 forks source link

Add download all attachments to messages. #2928

Open RubenGarcia opened 10 months ago

RubenGarcia commented 10 months ago

docs: Document additional packages needed in ubuntu fix: Changes to save multiple attachments in same message with a different name.

First time contributor checklist:

[x] I have read the README and Contributor Guidelines

Contributor checklist:

[x] My commits are in nice logical chunks with good commit messages
[x] My changes are rebased on the latest clearnet branch
[x] A yarn ready run passes successfully (more about tests here)
[x] My changes are ready to be shipped to users

Description

This merge request builds on https://github.com/oxen-io/session-desktop/pull/2917 (https://github.com/oxen-io/session-desktop/issues/2743) and adds the possibility to download all attachments to a directory in one go.

Bilb commented 9 months ago

Hey, could we instead of relying on those chrome experimental features,

show a picker to choose the folder,
get the full path of that folder,
send that folder, a Array<{filename:string, plaintext: Uint8Array} to the main side of electron and have it create the files and fill the content of it?

RubenGarcia commented 9 months ago

Hey, could we instead of relying on those chrome experimental features,

* show a picker to choose the folder,

* get the full path of that folder,

* send that folder, a Array<{filename:string, plaintext: Uint8Array} to the main side of electron and have it create the files and fill the content of it?

The last part I don't know how to do. I only activate the experimental features so I have access to the functions which save to disk in the background. I suppose they be available without enabling experimental once electron is updated, so we can wait until then and remove the line that enables experimental features.

Bilb commented 9 months ago

ok, I'll mark this PR as draft until then

RubenGarcia commented 8 months ago

v25.8.4 still needs the request for experimental features.

KeeJef commented 3 months ago

To ensure I understand correctly, this feature allows users to download all attachments of a message by selecting an option from the context menu that appears when clicking on a message with multiple attachments. Does this action prompt the user to choose a save location via a file picker, or are the attachments automatically saved to a default location?

Does this still rely on Chrome experimental features?

RubenGarcia commented 3 months ago

It asks the user to select a directory. I think the feature is still marked as experimental, but I have not checked lately.