Sometimes clipping happens when reverb volume is on maximum

oxesoft / oxefmsynth

Oxe FM Synth official repository

https://oxesoft.wordpress.com/

GNU General Public License v3.0

178 stars 27 forks source link

Sometimes clipping happens when reverb volume is on maximum #23

Open Boscop opened 6 years ago

Boscop commented 6 years ago

When I put the reverb volume on maximum and play certain notes with certain patches (e.g. program 48: PercOrgan) the sound is clipping. Maybe it makes sense to have a master volume knob or a simple internal compressor like sylenth? (or a tube waveshaper as soft knee limiter)

djtuBIG-MaliceX commented 3 years ago

See #16

djtuBIG-MaliceX commented 3 years ago

Raised PR https://github.com/oxesoft/oxefmsynth/pull/33 to address the bad distortion on max volume reverb. It however does not address the internal clipping done by Oxe globally - there's some refactoring required to change its signal summation to use floating point.