search

oxesoft / oxefmsynth

Oxe FM Synth official repository
https://oxesoft.wordpress.com/
GNU General Public License v3.0
178 stars 27 forks source link

Two minor compilation fixes for g++/ubuntu #27

Closed gi0e5b06 closed 5 years ago

gi0e5b06 commented 5 years ago

(g++ version 7.3.0 / Ubuntu 18.04.1 LTS) Except that (and finding the vstsdk), I could compile it without problems. Works well and sounds good. Thanks.

umbeebmu commented 5 years ago

Tried compiling in (g++ version 7.3.0 / Ubuntu 18.04.1 LTS): your fixes are ok, but additionally I found many issue in buildingbitmaps.cpp: error: narrowing conversion of ‘224’ from ‘int’ to ‘char’ inside { } [-Wnarrowing] I could fix those changing the type from car to unsigned char. Did you also found the same issue?

oxesoft commented 5 years ago

Great! Thanks for you contribution. Tested in Ubuntu 18.04.

gi0e5b06 commented 5 years ago

@umbeebmu I did. This is why I modified src/toolkits/embedresources.cpp. @oxesoft That was fast :) Thanks for merging.