search

oxfist / night-owl.nvim

🦉 🌌 Night Owl colorscheme implementation for Neovim with support for Treesitter and semantic tokens
BSD 3-Clause "New" or "Revised" License
257 stars 17 forks source link

Feature Request: Add support for Night Owl Light #17

Open andybroger opened 1 year ago

andybroger commented 1 year ago

Hello

First, a wonderful implementation of the original theme. Is there a plan to also implement Night Owl Light? As i frequently switch between Light/Dark Mode.

oxfist commented 1 year ago

Hey @andybroger! Thanks so much for your kind words. I didn't have the chance to respond earlier.

So far I don't have the implementation of a light version of the theme in the roadmap. I'm currently working on ensuring support for a few languages that I see as good incentives to increase adoption. Considering past contributions and current number of stars, I think I'm on the right track.

A light version will for sure make this implementation better, but it would require a fair amount of work. I've not delved too much into Lua configurations for this theme and currently have no tests whatsoever as my main priority has been better language support.

If this issue gets more support I would definitely consider it a higher priority. It would also be useful to know which languages you use and would want support for with a light version.

My overall goal is to have a full and excellent implementation of the original theme, because I love it so much, and even go beyond that, considering Sarah has not had updates for the VSCode theme for a while now.

hiyorijl commented 1 year ago

i'm also in favor of this too please, to add light version; it would be so pretty

ubmit commented 8 months ago

i'd love to have the light version 🙌

oxfist commented 5 months ago

Quick update:

Now that the theme can be configured using Lua, I have the base implementation I need to work on something like this:

require('night-owl').setup({
  -- ...
  light_mode = true,
})

I'm currently trying to organize the color palette of the theme based on the original VS Code implementation by Sarah, to which I've added a few tweaks for what I consider better consistency. Once I have that, I'm going to work on getting all the right mappings form dark to light mode, before refactoring the implementation to easily swap the hex values used.

Please leave a thumbs up if you're interested in having this option available! 👍🏼

luxus commented 2 months ago

the colorscheme is wonderful, looking forward to lightmode. maybe instead of a setup option it would be nice to use the background option of neovim?