search

oxfordcontrol / Clarabel.cpp

Clarabel.cpp: C/C++ interface to the Clarabel Interior-point solver for convex conic optimisation problems.
Apache License 2.0
32 stars 10 forks source link

Updating C++ wrapper for 0.8 - Happy to make a PR #38

Closed mipals closed 1 month ago

mipals commented 2 months ago

Hi there,

I wanted to try out the Chordal decomposition added in 0.8 using the C++ wrapper. Turned out I needed to do a few modifications to the wrapper due to the API additions. At the same time I noticed that a few tests were missing, so I added them. The changes can be seen on my fork

If you want I can make a PR. That being said, I am not very experienced in C++ and Rust, so my code is probably substandard.

Cheers, Mikkel

goulart-paul commented 2 months ago

I upgraded the wrappers already in the develop branch, and I don't now remember why I didn't merge it. I will take a look.

mipals commented 2 months ago

I do not know why I did not think of checking other branches. Well, I can migrate the missing tests to the develop branch.

goulart-paul commented 2 months ago

I have merged an update to v0.8.1 to main in #39. I haven't tagged it as v0.8.1 here yet. Tests are good, so happy to have include more tests if you have them.

mipals commented 2 months ago

Thanks for the update. I will make a PR adding the tests.

goulart-paul commented 1 month ago

Thanks. I have merged both the develop branch and your tests from #40, which I think resolves this issue.