oxfordcontrol / Clarabel.jl

Clarabel.jl: Interior-point solver for convex conic optimisation problems in Julia.
Apache License 2.0
174 stars 16 forks source link

Pg/soc small cones speedup #137

Closed goulart-paul closed 1 year ago

goulart-paul commented 1 year ago

Improves numerical efficiency in problems with a large number of small SOCs by removing @views in favor of explicit loops with @inbounds.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 73.12% and project coverage change: -1.36% :warning:

Comparison is base (50b0c6e) 82.22% compared to head (eb3ff93) 80.87%. Report is 10 commits behind head on main.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #137 +/- ## ========================================== - Coverage 82.22% 80.87% -1.36% ========================================== Files 37 39 +2 Lines 2701 2803 +102 ========================================== + Hits 2221 2267 +46 - Misses 480 536 +56 ``` | [Files Changed](https://app.codecov.io/gh/oxfordcontrol/Clarabel.jl/pull/137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oxfordcontrol) | Coverage Δ | | |---|---|---| | [src/cones/coneops\_defaults.jl](https://app.codecov.io/gh/oxfordcontrol/Clarabel.jl/pull/137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oxfordcontrol#diff-c3JjL2NvbmVzL2NvbmVvcHNfZGVmYXVsdHMuamw=) | `15.55% <0.00%> (-7.18%)` | :arrow_down: | | [src/equilibration.jl](https://app.codecov.io/gh/oxfordcontrol/Clarabel.jl/pull/137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oxfordcontrol#diff-c3JjL2VxdWlsaWJyYXRpb24uamw=) | `97.95% <ø> (ø)` | | | [src/precompile.jl](https://app.codecov.io/gh/oxfordcontrol/Clarabel.jl/pull/137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oxfordcontrol#diff-c3JjL3ByZWNvbXBpbGUuamw=) | `0.00% <0.00%> (ø)` | | | [src/settings.jl](https://app.codecov.io/gh/oxfordcontrol/Clarabel.jl/pull/137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oxfordcontrol#diff-c3JjL3NldHRpbmdzLmps) | `4.44% <0.00%> (-3.56%)` | :arrow_down: | | [src/variables.jl](https://app.codecov.io/gh/oxfordcontrol/Clarabel.jl/pull/137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oxfordcontrol#diff-c3JjL3ZhcmlhYmxlcy5qbA==) | `77.64% <ø> (+11.64%)` | :arrow_up: | | [src/version.jl](https://app.codecov.io/gh/oxfordcontrol/Clarabel.jl/pull/137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oxfordcontrol#diff-c3JjL3ZlcnNpb24uamw=) | `28.57% <0.00%> (ø)` | | | [src/Clarabel.jl](https://app.codecov.io/gh/oxfordcontrol/Clarabel.jl/pull/137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oxfordcontrol#diff-c3JjL0NsYXJhYmVsLmps) | `55.55% <42.85%> (-44.45%)` | :arrow_down: | | [src/utils/mathutils.jl](https://app.codecov.io/gh/oxfordcontrol/Clarabel.jl/pull/137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oxfordcontrol#diff-c3JjL3V0aWxzL21hdGh1dGlscy5qbA==) | `80.98% <50.00%> (+3.77%)` | :arrow_up: | | [src/types.jl](https://app.codecov.io/gh/oxfordcontrol/Clarabel.jl/pull/137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oxfordcontrol#diff-c3JjL3R5cGVzLmps) | `85.71% <70.00%> (-0.65%)` | :arrow_down: | | [src/MOI\_wrapper/MOI\_wrapper.jl](https://app.codecov.io/gh/oxfordcontrol/Clarabel.jl/pull/137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oxfordcontrol#diff-c3JjL01PSV93cmFwcGVyL01PSV93cmFwcGVyLmps) | `85.27% <91.66%> (+0.30%)` | :arrow_up: | | ... and [17 more](https://app.codecov.io/gh/oxfordcontrol/Clarabel.jl/pull/137?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oxfordcontrol) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/oxfordcontrol/Clarabel.jl/pull/137/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oxfordcontrol)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.