search

oxfordpython / oxfordpython.com

Creative Commons Zero v1.0 Universal
1 stars 0 forks source link

upgrade to django 2.0 and add mock urls/views for all the issues #3

Closed lpmi-13 closed 6 years ago

lpmi-13 commented 6 years ago

this may be an incredibly uncouth method of upgrading to django 2.0, but figured I'd give it a bash and see what people think. Happy to change any of this and/or just make incremental changes on smaller feature branches to the original repo, but figured as we're starting more or less from square 1, might as well just start a new project 2.0-style.

Fully intending to refactor as we go.

craigloftus commented 6 years ago

I'd stick to atomic PRs. It is much easier to review, merge and make progress.

From a quick scan for Django 2 support we only need the change to MIDDLEWARE and removing the reference to SessionAuthenticationMiddleware

lpmi-13 commented 6 years ago

Thanks for the comments, Craig and Ian...just the kind of feedback I was looking for!

I'll get on this and hopefully have a revised PR posthaste.

lpmi-13 commented 6 years ago

alright, made another feature branch for just the django version upgrade, and will close this and open a PR from there.