search

oxfordpython / oxfordpython.com

Creative Commons Zero v1.0 Universal
1 stars 0 forks source link

update urls to be in line with django 2.0 conventions #5

Closed lpmi-13 closed 6 years ago

lpmi-13 commented 6 years ago

update to use path instead of url, which seems to be recommended with Django 2.x, though happy to discuss if that's not the way to go.

lpmi-13 commented 6 years ago

Ah of course. Forgot to pull on single_pages after my own PR was merged. Will sort!

On Mon, 19 Mar 2018, 08:30 Craig Loftus, notifications@github.com wrote:

@craigloftus requested changes on this pull request.

The PR isn't based on the HEAD of the single_page branch, it hasn't caused a merge conflict in this instance but it did make testing it a bit confusing.

In oxfordpython/urls.py https://github.com/oxfordpython/oxfordpython.com/pull/5#discussion_r175357272 :

from django.contrib import admin

from .main import views as main_views

urlpatterns = [

  • url(r'^admin/', admin.site.urls),
  • url(r'^$', main_views.HomeView.as_view(), name='home'),
  • path('admin', admin.site.urls),

This should be admin/; You end up with urls like adminlogin otherwise.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/oxfordpython/oxfordpython.com/pull/5#pullrequestreview-104870287, or mute the thread https://github.com/notifications/unsubscribe-auth/AE1etGKGdkdMubrclpWEQoRdr9t--uJ4ks5tf2y1gaJpZM4SvWzA .

lpmi-13 commented 6 years ago

decided to close this, as I wanted to add some test cases and starting from a new branch seemed sensible for that fresh clean feeling.