Don't try to gen deterministic data if joining a public chain

oxheadalpha / tezos-k8s

Deploy a Tezos Blockchain on Kubernetes

https://tezos-k8s.io/

MIT License

50 stars 26 forks source link

Don't try to gen deterministic data if joining a public chain #162

Open harryttd opened 3 years ago

harryttd commented 3 years ago

The bug is likely here:

It should probably be:

if SHOULD_GENERATE_UNSAFE_DETERMINISTIC_DATA and not THIS_IS_A_PUBLIC_NET:
        fill_in_missing_genesis_block()
        all_accounts = fill_in_missing_baker_accounts()

Also, this is something that should be validated by Helm via json schema and/or manual Helm templating checks.

elric1 commented 3 years ago

If we think that this is a bug, we should have the helm chart throw an error so that the user gets feedback more quickly.