search

oxheadalpha / tezos-k8s

Deploy a Tezos Blockchain on Kubernetes
https://tezos-k8s.io/
MIT License
50 stars 26 forks source link

update pyyaml to 6.0.1 #596

Closed orcutt989 closed 1 year ago

orcutt989 commented 1 year ago

Fixes broken pyyaml arm64 build in our CI.

harryttd commented 1 year ago

Please see my comment here: https://github.com/oxheadalpha/tezos-k8s/pull/595#issuecomment-1648728333 I believe we should wait for the maintainers to fix.

orcutt989 commented 1 year ago

Please see my comment here: #595 (comment) I believe we should wait for the maintainers to fix.

Thanks @harryttd. Yes I looked at the PR and I wasn't able to understand the issue. It seems as if the arm64 build randomly stopped working for PyYAML 5.4. Could you elaborate on how the PR could be related?

This seems more relevant possibly https://github.com/yaml/pyyaml/issues/724

I did some research and along with the above- the consensus seems to be to upgrade to 6.0.1. I spoke with @nicolasochem about upgrading and he didnt think there would be issue.

Happy to wait, but we have a broken pipeline at the moment.

orcutt989 commented 1 year ago

I see now how the Cython PR is relevant. However I dont think its going to be fixed.

https://github.com/yaml/pyyaml/issues/734#issuecomment-1652102940

harryttd commented 1 year ago

Yeah.. as the days go on they don't seem to want to fix this for older versions https://github.com/yaml/pyyaml/pull/731

Did you test the code to make sure it still works with the major release version?

nicolasochem commented 1 year ago

Did you test the code to make sure it still works with the major release version?

We are not doing anything fancy with pyyaml so I'll assume it can still parse our yaml fine.