search

oxidecomputer / amd-apcb

AMD Generic Encapsulated Software Architecture Platform Security Processor Configuration Block manipulation library
Mozilla Public License 2.0
13 stars 1 forks source link

ErrorOutControlBeepCodePeakAttr default impl is weird #30

Closed daym closed 2 years ago

daym commented 2 years ago 
    impl Default for ErrorOutControlBeepCodePeakAttr {
        fn default() -> Self {
            ErrorOutControlBeepCodePeakAttr {
                bytes: [0, 0, 0, 0],
            }
        }
    }

That uses an implementation detail of modular_bitfield.

Better would be to just use new().

daym commented 2 years ago

Deleted in commit 44a17f2bbff99c9def663e7076e5b88de8cb0d52