search

oxidecomputer / amd-apcb

AMD Generic Encapsulated Software Architecture Platform Security Processor Configuration Block manipulation library
Mozilla Public License 2.0
13 stars 1 forks source link

serializers: Future-proof usage of schemars #48

Closed daym closed 2 years ago

daym commented 2 years ago

Fixes https://github.com/oxidecomputer/amd-apcb/issues/33.

daym commented 2 years ago

Tested that resulting milan-ethanol-x.img is bitwise identical before and after the change.

daym commented 2 years ago

I totally agree there needs to be some kind of human-readable change tracking.

But, here, there already is a ticket and it's referenced in the commit message.

I can change the format of the commit message though (?).

But I did elaborate much more in the linked issue https://github.com/oxidecomputer/amd-apcb/issues/33 now.

daym commented 2 years ago

Since this is a trait method and it looks like schemars::JsonSchema is a public trait, it automatically has public visibility (right?).

Yes.

Thanks for the review!