Closed mattsse closed 3 years ago
Hey, this is a great change! I created a variant of it here which simplifies trait bounds, and I think which aligns with the synchronous usage of SaveChangesDsl a little more closely.
What do you think?
awesome, that looks great, the trait bounds were horrendous :)
closing this in favor of #3
This tries to fix the lifetime problem mentioned in #1.
It does so by basically copying all trait bounds and implementation over from
UpdateAndFetchResults
. There still some issues:Identifiable
derive macro implements for reference, this needs to be implemented by handCopy
, this requires aClone
now which is not ideal.It should be possible however to come up with a solution that prevents at least the
Clone
, but the diesel traits are so intertwined that it's not trivial at first glance.