Closed smklein closed 3 years ago
Currently, the codebase has a couple spots where error-handling is... uh... basically not done:
https://github.com/oxidecomputer/async-bb8-diesel/blob/f0dbc0dddadfe8ac9f47a65eb3f56d73376f86ed/src/lib.rs#L165-L174
The reasoning here is that this error-handling would propagate bb8::Pool errors in addition to Diesel errors, forcing clients to handle the combination of both. This should be done, but it will also require updating clients using this library.
Currently, the codebase has a couple spots where error-handling is... uh... basically not done:
https://github.com/oxidecomputer/async-bb8-diesel/blob/f0dbc0dddadfe8ac9f47a65eb3f56d73376f86ed/src/lib.rs#L165-L174
The reasoning here is that this error-handling would propagate bb8::Pool errors in addition to Diesel errors, forcing clients to handle the combination of both. This should be done, but it will also require updating clients using this library.