oxidecomputer / async-bb8-diesel

Safe asynchronous access to Diesel and the bb8 connection manager
MIT License
12 stars 8 forks source link

Add function for automatic transaction retry #58

Closed smklein closed 10 months ago

smklein commented 11 months ago

Attempts to implement https://www.cockroachlabs.com/docs/v23.1/advanced-client-side-transaction-retries

This functionality includes some cockroach-specific calls, so it exists behind a new cockroach feature flag.

smklein commented 11 months ago

Putting this up for review as I finish up usage in https://github.com/oxidecomputer/omicron/pull/4487

There are some transactions which I am not converting, but I believe the shape of things largely makes sense there as an integration PR.

smklein commented 10 months ago

Appreciate the comments - do y'all have any other feedback for this PR? I'm told that this should be part of the release candidate, which is planned to be created tomorrow.