search

oxidecomputer / buildomat

a software build labour-saving device
Mozilla Public License 2.0
53 stars 2 forks source link

we should opportunistically compress responses #58

Open iliana opened 1 month ago

iliana commented 1 month ago

Check run pages (e.g. https://buildomat.eng.oxide.computer/wg/0/details/01J04QGAYSFEA32EPBNB1NN9FA/rO6E1KLuz95lg5PhVtAw9IPDufYTSB5Uq4cxNubZy3ZUZVrG/01J04QHG82RKM5TEJTW822P8FP) can get quite large; this one is 3.56 MiB, but gzips to 275.51 KiB. Either Buildomat or Nginx could compress the response per the client's accept-encoding header.

jclulow commented 1 month ago

Yes that is not a bad idea!

Something else I've been considering is paginating the output somehow, given that sometimes it can be more than ten times even that size.

iliana commented 1 month ago

Pagination might not immediately work well for me, since I tend to use my browser's find-in-page feature to look for the particular line I need for a given job failure. But there might be other ways of performing that functionality.

jclulow commented 1 month ago

That is indeed the main thing that has kept me from doing it haha. I'll look at the compression!