Side modals do not animate in on the VPC sub-pages

[benjaminleonard]

They appear instantaneously. At first I thought it might be something to do with the fact the other modals are navigated to through the router but the new disk page on the instance page seems to animate in just fine.

[benjaminleonard]

https://github.com/oxidecomputer/console/blob/ca7c85de20f750a7444e8895e25b6368493483aa/app/components/form/SideModalForm.tsx#L45-L47

Here's the responsible line – new firewall rule is not it's own route and therefore does not animate. Perhaps related to #1913 since I am guessing we can't keep the tab as a param and have the modal as a route.

[david-crespo]

Fixed by #2249