search

oxidecomputer / console

Oxide Web Console
https://console-preview.oxide.computer
Mozilla Public License 2.0
125 stars 10 forks source link

Instances: Optional / inline pagination for networking interfaces #1988

Open benjaminleonard opened 6 months ago

benjaminleonard commented 6 months ago

We should either have the option to disable the fixed pagination or have a version that is directly underneath the table for instances like this:

image.png

david-crespo commented 6 months ago

I didn't think NICs are even paginated, but it looks like they are. I was hoping we could just drop the pagination UI altogether. There is a pretty low limit on the number of NICs an instance can have.

https://github.com/oxidecomputer/omicron/blob/d514878f417a94247791bd5564fbaafa9b4170a0/nexus/src/external_api/http_entrypoints.rs#L3856-L3893

david-crespo commented 6 months ago

Actually... we can fudge this. Even if the endpoint is really paginated, as long as we request a large enough number that we can be sure we got them all, we can still hide the pagination controls. And unlike with other resources, that number is like... 20.

benjaminleonard commented 6 months ago

I think that's the best fit for this specifically, though we might revisit that in the future if we want all our inline tables to behave the same (that is have some inline pagination no matter how many items we expect)? The pagination could be client-side if we just want to request a really high number to avoid the complexity of dealing with server-side pagination unnecessarily.