search

oxidecomputer / console

Oxide Web Console
https://console-preview.oxide.computer
Mozilla Public License 2.0
145 stars 12 forks source link

Warn if booting without any attached disks #2279

Open mkeeter opened 5 months ago

mkeeter commented 5 months ago

It's possible to stop an instance, remove its disks, then try to boot it.

It's hard to imagine this not being a user error, unless someone really wants to play with the UEFI Interactive Shell.

david-crespo commented 5 months ago

I am guessing you considered and rejected having the API refuse to do that? Should be pretty easy to warn on the client.

david-crespo commented 4 months ago

We'd have to pass instance disks (or at least a flag saying there are no attached disks) to the instance actions helper and then add a confirm here if there are none.

https://github.com/oxidecomputer/console/blob/4147221c3d4d5ff2552bc6b4130ada1741c7e690/app/pages/project/instances/actions.tsx#L51-L67