search

oxidecomputer / crucible

A storage service.
Mozilla Public License 2.0
164 stars 16 forks source link

Remove the `Url` `VolumeConstructionRequest` type #1046

Open leftwo opened 9 months ago

leftwo commented 9 months ago

I think once Omicron #2898 lands, we can remove the Url VolumeConstructionRequest type as well.

Originally posted by @leftwo in https://github.com/oxidecomputer/omicron/issues/2898#issuecomment-1843927189

jmpesp commented 9 months ago

This should only happen when all the existing VolumeConstructionRequest objects have been checked to see that they don't contain this variant, else they may fail to deserialize. A possible prerequisite could be to scrub blocks from all read-only parents so that they land on region storage, then drop the read-only parents - this drops all VCRs with a Url variant and we can remove that variant in as part of this issue.