Closed plainspace closed 4 years ago
Looks super neat!
I've proposed three changes on my fork if you want to review them!
Layout
min-width: 60rem
to split layout vertically first, then horizontally On Exit Button
onClick
and id
, just use href="{{.Site.BaseURL}}"
directlyI've just increased the button size a bit, but best practices tells that on smaller layout, 44px
should be the minimum size for elements with finger interactions.
It would just require to move things around a bit, but I wanted to read what were your thoughts first :)
@lovethebomb I cherry-picked those commits and made a couple of others. What do you think?
I've added comments but LGTM otherwise 👍 !
This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/oxidecomputer/design-site/dqq6det5j ✅ Preview: https://design-site-git-pr-38-layout.oxidecomputer.now.sh