search

oxidecomputer / design-site

We are looking for designers who code to help build a new user experience for computing!
https://design.oxide.computer
MIT License
98 stars 34 forks source link

Small code improvements #6

Closed daisygabi closed 4 years ago

daisygabi commented 4 years ago

User Case: Send a PR with any improvement

Solution: I am not a designer, but I wanted to add my small improvements to this. I have taken into consideration to make the links accessable and use web safe colors. For more information about this please check: https://whocanuse.com/?b=3366FF&c=FFFFFF&f=20&s= Extracting the colors and basic properties in a variables.css file makes it easier for later to modify all of them from one place only.

jessfraz commented 4 years ago

This looks great! Thank you so much, unfortunately since I am going in order of "first in, first to be merged" there is a conflict, do you mind fixing? Thank you!

daisygabi commented 4 years ago

~I couldn't figure out how to update this particular PR after upstream update and I had to create a new one.~ Never mind, figured it out. 😀

jessfraz commented 4 years ago

Seems like on mobile it looks a lot different now Screenshot_20191204-065525

daisygabi commented 4 years ago

When I merged the conflicts I missed two variables. I have fixed that and updated the PR.

daisygabi commented 4 years ago

I took a look at the last merge made, the modifications introduced variables and i think this PR is no longer needed. But it was fun, thank you :)

jessfraz commented 4 years ago

Sorry about that, thank you so much!!!

On Wed, Dec 4, 2019, 9:55 PM Gabriela Radu notifications@github.com wrote:

I took a look at the last merge made, the modifications introduced variables and i think this PR is no longer needed. But it was fun, thank you :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/oxidecomputer/design.oxide.computer/pull/6?email_source=notifications&email_token=AALA23AHEPEZNIC5JXIQP23QXCJTNA5CNFSM4JUV7ZRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF7SV7A#issuecomment-561982204, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALA23CH334FJVRK7CZHS6TQXCJTNANCNFSM4JUV7ZRA .